Source Code Review Form 
=======================
(version 1.1)

Date: 2004-11-12

1 Identification

1.1 Issue         : 1289
                    1291
                    1295
                    1300
1.2 Bugtraq       : 6194625
                    6176181
                    6174915
                    6185211
1.3 Summary       : Reduced overhead of suspending subordinate queues
                    Fixed qdel "" segfault
                    Added missing qconf return codes
                    Made initial job environment configurable                    
1.4 Changelog ID  : DT-2004-11-12-0
1.5 Developer(s)  : DT
1.6 Reviewer(s)   : EB
                    AH
                    SG
                    SG, AA, AS


2 Conformance to specification

2 [x] yes
2 [ ] no - comment:


3 Documentation

3.1 user/admin guide
3.1 [x] yes
3.1 [ ] no - comment:

3.2 man pages (user view)
3.2 [x] yes
3.2 [ ] no - comment:

3.3 -help output
3.3 [x] yes
3.3 [ ] no - comment:

3.4 documented interfaces (at least GDI, EVI, libs)
3.4 [x] yes
3.4 [ ] no - comment:

3.5 messages, output formats
3.5 [x] yes
3.5 [ ] no - comment:


4 Source review

4.1 Style guide conformance
4.1 [x] yes
4.1 [ ] no - comment:

4.2 Memory leaks
4.2 [x] yes
4.2 [ ] no - comment:

4.3 Thread safe
4.3 [X] yes
4.3 [ ] no -


5 Tests

5.1 flawfinder diff
5.1 [x] yes
5.1 [ ] no - comment:

5.2 Used memory leak debugger
5.2 [x] yes - comment: 1289, 1291, 1295
5.2 [x] no - comment: 1300 is the child of a fork and exec

5.3 Manual tests
Description: See comments in IZ1289
             Ran qdel "" with new qmaster and old and new qdel
             Ran qconf with various cluster queue and host group options
             Ran "qsub -b y -shell n env" and checked results
Successfull execution
5.3 [x] yes
5.3 [ ] no - comment:

5.4 Testsuite covers issue
5.4 [x] yes - comment: 1291
5.4 [ ] no - comment: 1289 and 1300 are too complicated for the test suite

5.5 If 5.4 = no: Testsuite issue created
5.5 [x] yes - comment: 1295
5.5 [ ] no - comment:

5.6 Testsuite run successfull
5.6 [x] yes
5.6 [ ] no - comment:



6 Comments

7 Accepted
7 [x] yes
7 [ ] no - comment:


